gh-154942: Refresh statistics.kde cache after same-length data changes - #155034
Open
Taeknology wants to merge 1 commit into
Open
gh-154942: Refresh statistics.kde cache after same-length data changes#155034Taeknology wants to merge 1 commit into
Taeknology wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154942.
statistics.kde()now detects changes to the contents of mutable data sequences for bounded-support kernels. Previously, its sorted sample cache was refreshed only when the sequence length changed, so replacing a value without changing the length could produce a stale estimate.The bounded-support path now compares the current data with a tuple snapshot and rebuilds the sorted sample only when the contents change. This preserves online updates while keeping bounded- and unbounded-support kernels consistent.
The statistics test suite passes, including new regression coverage for PDF and CDF estimates after a same-length value replacement.